refactor #1

Merged

DragonSpirit merged 10 commits from refactor into main 2026-05-14 23:34:13 +03:00

Conversation 0 Commits 10 Files Changed 81

+3685 -3036

DragonSpirit commented 2026-05-14 23:33:14 +03:00

Owner

Copy Link

Copy Source

No description provided.

DragonSpirit added 10 commits 2026-05-14 23:33:14 +03:00

refactor: phase 0 & 1 b5c506cf03

phase 5: transfer service 895fee6235

refactor: phases 5 & 6 — TransferService, Result<T>, RAII ... dc65a4c8a9

Phase 5 — TransferService extraction:
- New nxst::TransferService owns all sender/receiver state, threads, and atomics
  (previously 11 file-statics across transfer_sender.cpp + transfer_receiver.cpp)
- startReceive() calls io::restore internally; UI never touches infra/fs or infra/net
- TitlesLayout routes all transfer ops through mainApp->transfer
- g_currentUId removed from global scope; TitlesLayout::InitTitles(AccountUid)
- MainApplication gains transfer member; layout refs renamed to snake_case
- userAppExit() updated to cancel via service

Phase 6 — Result<T> + RAII:
- include/nxst/domain/result.hpp: 85-line tagged-union Result<T,E> + Result<void,E>
- include/nxst/infra/fs/handles.hpp: FsFileSystemHandle (auto fsFsClose),
  FileHandle (auto fclose) — eliminates manual close on every error path
- io::backup / io::restore return nxst::Result<std::string> (was tuple<bool,Result,string>)
- new u8[] + malloc in copyFile/restore replaced with std::vector<u8>
- NACP save-creation extracted to createSaveIfNeeded() helper in io.cpp

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

finish refactor, add docs and CI 9339e7dbfe

chore: remove vendored deps/asprintf ... 33a1ce73af

vasprintf/asprintf are provided by devkitpro newlib (<stdio.h>).
deps/asprintf was never compiled by CMake (GLOB_RECURSE covers src/ only).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

build: migrate Plutonium to ExternalProject_Add + IMPORTED target ... 82df796a4a

Replaces add_custom_command/add_custom_target with ExternalProject_Add,
which correctly declares BUILD_BYPRODUCTS for Ninja and propagates include
paths via INTERFACE_INCLUDE_DIRECTORIES on the IMPORTED STATIC target.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

build: replace Plutonium submodule with ExternalProject_Add fetch ... 9b18a32b0c

Plutonium is now downloaded at build time via ExternalProject_Add
(GIT_REPOSITORY + GIT_TAG) instead of being a git submodule.
Removes lib/, .gitmodules, and the linguist-vendored entry for it.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

chore: remove stale deps/** linguist-vendored from .gitattributes ... 836956394a

deps/ directory was removed with asprintf cleanup.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor: phase 6 cleanup — RAII handles and io::restore split ... 6f8ede035f

- AccountProfileHandle RAII wrapper in handles.hpp; applied in
  account.cpp (getUser, iconPath) replacing manual accountProfileClose
- FILE* in iconPath replaced with existing FileHandle RAII wrapper
- io::restore split into clearSaveRoot + extractAndCommit static helpers;
  public signature unchanged
- sendAll/recvAll kept as bool — callers don't propagate the error string,
  Result<void> would add noise without benefit

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

another stage of refactoring 49efcde301

DragonSpirit merged commit 1111f691c6 into main 2026-05-14 23:34:13 +03:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

DragonSpirit

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DragonSpirit/NXST#1